Add ItemDivider in NotificationActivity #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use DividerItemDecoration to add ItemDivider in RecycleView
* ButterKnife already used
Codecov Report
@@ Coverage Diff @@
## master #1193 +/- ##
=========================================
- Coverage 3.82% 3.82% -0.01%
=========================================
Files 125 125
Lines 5798 5799 +1
Branches 568 568
=========================================
Hits 222 222
- Misses 5561 5562 +1
Partials 15 15
Continue to review full report at Codecov.
|
maskaravivek
approved these changes
Feb 24, 2018
|
Looks good to me. Will wait for @neslihanturan, our UI expert ;) to take a look before me merge it. |
|
Thanks for the PR @ayushin78 ! Looks good to me, too. :) |
|
Have tested on a real device. Works fine. Going ahead and merging it. :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1186
Added ItemDivider in NotificationActivity using DividerItemDecoration
Screenshots showing what changed
Before
After